Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(table): fix the bottom slot content of table is missing when usin… #3419

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(table): fix the bottom slot content of table is missing when usin… #3419

wants to merge 1 commit into from
+6 −2

Conversation

gangchn
Copy link

@gangchn gangchn commented Jan 11, 2025 •
edited
Loading

…g the window.print() method in a browser (#3242)

Types of changes

  • New feature
  • Bug fix
  • Enhancement
  • Component style change
  • Typescript definition change
  • Documentation change
  • Coding style change
  • Refactoring
  • Test cases
  • Continuous integration
  • Breaking change
  • Others

Background and context

Close #3242.

Solution

We will use grid layout to expend the spin space instead of using flex layout.

How is the change tested?

Noting change.

Changelog

Component Changelog(CN) Changelog(EN) Related issues
table 修复在浏览器中使用 window.print() 方法时，表格底部插槽内容缺失的问题。 fix the bottom slot content of the Arco table is missing when using the window.print() method in a browser. #3242

Checklist:

  • Test suite passes (npm run test)
  • Provide changelog for relevant changes (e.g. bug fixes and new features) if applicable.
  • Changes are submitted to the appropriate branch (e.g. features should be submitted to feature branch and others
    should be submitted to main branch)

Other information

Nothing else.

@codesandbox CodeSandbox
Copy link

codesandbox bot commented Jan 11, 2025

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

@oljc oljc added the 🙅 Invalid This doesn't seem right label Jan 11, 2025
@oljc
Copy link
Member

oljc commented Jan 11, 2025

@gangchn 感谢 PR🙏！这个问题与浏览器在执行打印导出 PDF 时的默认渲染行为有关，组件库无法完全控制。此外 PR 中样式改动可能影响现有版本布局，建议使用第三方库实现打印操作。

@gangchn
Copy link
Author

gangchn commented Jan 11, 2025 •
edited
Loading

@oljc 感谢回复，我的看法和你相反。我认为这和浏览器执行打印 PDF 时的默认渲染行为没太大关系，我这里还有另一个同样场景的 例子 可以佐证我的观点。

  1. Ant Design Vue 在相同场景下（页面跨页且使用原生 window.print() 打印）就不会出现你所说的问题。
  2. PR中样式的改动，我在 Table 组件下文档提供的案例中均已验证过，没有出现异常情况。

如上，如果有误请予以纠正，感谢。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🙅 Invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The bottom slot content of the Arco table is missing when using the window.print() method in a browser
2 participants
@gangchn @oljc